Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common directive docs #11581

Closed
wants to merge 1 commit into from
Closed

Common directive docs #11581

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Sep 14, 2016 •
edited

TODO

  • add runnable examples -> will be addressed later
  • check design by building the docs.

@vicb vicb added state: WIP compX: docs area: common Issues related to APIs in the @angular/common package labels Sep 14, 2016
@vicb vicb changed the title [wip] common directive docs Common directive docs Sep 14, 2016
@vicb vicb removed the state: WIP label Sep 14, 2016
tbosch
tbosch reviewed Sep 14, 2016
View reviewed changes
modules/@angular/common/src/directives/ng_class.ts
* }
* }
* ```
* The `Object`-based version is the most usual as it has the advantage of keeping all the CSS class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also true for the other cases, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, removed

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 14, 2016
@IgorMinar IgorMinar closed this in 9cee8bc Sep 14, 2016
@vicb vicb deleted the 0912-docs branch June 9, 2017 17:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tbosch tbosch tbosch left review comments

Assignees
No one assigned
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: common Issues related to APIs in the @angular/common package cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vicb @tbosch @googlebot