Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): do not update primary route if only secondary outlet is … #11797

Merged
merged 1 commit into from Oct 20, 2016
Merged

fix(router): do not update primary route if only secondary outlet is … #11797

merged 1 commit into from Oct 20, 2016

Conversation

mucer
Copy link
Contributor

@mucer mucer commented Sep 21, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
If I just want to navigate a secondary outlet, the primary route is cleard (see added test).

If the inital route would be set to

router.navigateByUrl('/team/22/(user/victor)');

it would be possible to change just the secondary route, without this fix.

What is the new behavior?
The router detects where the old primary route starts and keeps it.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…given

@mucer mucer closed this Sep 21, 2016
@mucer mucer reopened this Sep 21, 2016
@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer area: router labels Sep 21, 2016
@mucer
Copy link
Contributor Author

mucer commented Oct 8, 2016

I have created an issue for this PR: #12168

@vsavkin vsavkin added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 19, 2016
@alxhub alxhub merged commit da5fc69 into angular:master Oct 20, 2016
btrigueiro pushed a commit to btrigueiro/angular that referenced this pull request Oct 21, 2016
@mucer mucer deleted the fix-only-secondary-route branch October 24, 2016 07:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants