fix(router): do not update primary route if only secondary outlet is … #11797

Merged
merged 1 commit into from Oct 20, 2016

Conversation

Projects
None yet
5 participants
@mucer
Contributor

mucer commented Sep 21, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
If I just want to navigate a secondary outlet, the primary route is cleard (see added test).

If the inital route would be set to

router.navigateByUrl('/team/22/(user/victor)');

it would be possible to change just the secondary route, without this fix.

What is the new behavior?
The router detects where the old primary route starts and keeps it.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…given

@mucer

This comment has been minimized.

Show comment
Hide comment
@mucer

mucer Oct 8, 2016

Contributor

I have created an issue for this PR: #12168

Contributor

mucer commented Oct 8, 2016

I have created an issue for this PR: #12168

@alxhub alxhub merged commit da5fc69 into angular:master Oct 20, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

btrigueiro added a commit to btrigueiro/angular that referenced this pull request Oct 21, 2016

@mucer mucer deleted the mucer:fix-only-secondary-route branch Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment