Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(NgModule): Fixed docs for NgModule.entryComponents #12006

Merged
merged 3 commits into from Oct 3, 2016
Merged

docs(NgModule): Fixed docs for NgModule.entryComponents #12006

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f732e3
docs(NgModule): Corrected the wording of the documentation of `entryC…
benelliott Sep 30, 2016
b5445d2
docs(NgModule): Remove redundant ComponentFactory mentions
benelliott Oct 3, 2016
c240fe4
docs(NgModule): Restore ComponentFactory/ComponentResolver links
benelliottgsa Oct 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 9 additions & 10 deletions modules/@angular/core/src/metadata/ng_module.ts
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ export interface SchemaMetadata { name: string; }

/**
* Defines a schema that will allow:
* - any non-angular elements with a `-` in their name,
* - any non-Angular elements with a `-` in their name,
* - any properties on elements with a `-` in their name which is the common rule for custom
* elements.
*
Expand Down Expand Up @@ -132,9 +132,9 @@ export interface NgModule {
imports?: Array<Type<any>|ModuleWithProviders|any[]>;

/**
* Specifies a list of directives/pipes/module that can be used within the template
* of any component that is part of an angular module
* that imports this angular module.
* Specifies a list of directives/pipes/modules that can be used within the template
* of any component that is part of an Angular module
* that imports this Angular module.
*
* ### Example
*
Expand All @@ -149,10 +149,9 @@ export interface NgModule {
exports?: Array<Type<any>|any[]>;

/**
* Defines the components that should be compiled as well when
* this component is defined. For each components listed here,
* Angular will create a {@link ComponentFactory ComponentFactory} and store it in the
* {@link ComponentFactoryResolver ComponentFactoryResolver}.
* Specifies a list of components that should be compiled when this module is defined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to duplicate here, ie {@link ComponentFactory}

also run gulp format after your changes to make the CI happy, thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant duplicate inside braces, not removing it will !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I misinterpreted the section of the diff you commented on and thought it was a recommendation! Should be fixed now.

* For each component listed here, Angular will create a {@link ComponentFactory}
* and store it in the {@link ComponentFactoryResolver}.
*/
entryComponents?: Array<Type<any>|any[]>;

Expand All @@ -164,7 +163,7 @@ export interface NgModule {
bootstrap?: Array<Type<any>|any[]>;

/**
* Elements and properties that are not angular Components nor Directives have to be declared in
* Elements and properties that are not Angular components nor directives have to be declared in
* the schema.
*
* Available schemas:
Expand All @@ -186,7 +185,7 @@ export interface NgModule {
}

/**
* NgModule decorator and metadata
* NgModule decorator and metadata.
*
* @stable
* @Annotation
Expand Down