Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve data of a parent Componentless route doesn't get merged into child in case of Promise #12032

Closed
mohatt opened this issue Oct 2, 2016 · 2 comments
Closed

Resolve data of a parent Componentless route doesn't get merged into child in case of Promise #12032

mohatt opened this issue Oct 2, 2016 · 2 comments
Labels
area: router type: bug/fix

Comments

@mohatt
Copy link

mohatt commented Oct 2, 2016 •
edited

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Current behavior
Resolve data of a parent Componentless route doesn't get merged into child route data if the resolve function returned a Promise. This might be related to #10494.

Expected behavior
The router should merge the resolve data of a componentless parent into the data of the children routes.

Minimal reproduction of the problem with instructions
Open the plunk https://plnkr.co/edit/TObpPAgok78iAoqFpYE5?p=preview and click on the four links shown, you will notice that the fourth link doesn't display the resolve data correctly.

What is the motivation / use case for changing the behavior?
Fix bug.

Please tell us about your environment:

  • OS: Ubuntu 16.04.1, Node: 6.7.0. NPM: 3.10.3

  • Angular version: 2.0.1

  • Browser: all

  • Language: TypeScript 2.0.3

  • Node (for AoT issues): node --version =
@zoechi
Copy link
Contributor

zoechi commented Oct 3, 2016

Seems related to #10494

@vsavkin vsavkin self-assigned this Oct 5, 2016
vsavkin added a commit to vsavkin/angular that referenced this issue Oct 5, 2016
@vsavkin
fix(router): parent resolve should complete before merging resolved data
de0c9cf 
Closes angular#12032
vsavkin added a commit to vsavkin/angular that referenced this issue Oct 5, 2016
@vsavkin
fix(router): parent resolve should complete before merging resolved data
85510db 
Closes angular#12032
@tbosch tbosch closed this as completed in 1681e4f Oct 6, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: router type: bug/fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vsavkin @vicb @mohatt @zoechi