fix(router): parent resolve should complete before merging resolved data

Closes angular#12032
vsavkin · Oct 5, 2016 · de0c9cf · de0c9cf
1 parent cf269d9
commit de0c9cf
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/modules/@angular/router/src/router.ts b/modules/@angular/router/src/router.ts
@@ -13,6 +13,7 @@ import {Subject} from 'rxjs/Subject';
 import {Subscription} from 'rxjs/Subscription';
 import {from} from 'rxjs/observable/from';
 import {of } from 'rxjs/observable/of';
+import {concatMap} from 'rxjs/operator/concatMap';
 import {every} from 'rxjs/operator/every';
 import {map} from 'rxjs/operator/map';
 import {mergeAll} from 'rxjs/operator/mergeAll';
@@ -692,7 +693,7 @@ export class PreActivation {
   resolveData(): Observable<any> {
     if (this.checks.length === 0) return of (null);
     const checks$ = from(this.checks);
-    const runningChecks$ = mergeMap.call(checks$, (s: any) => {
+    const runningChecks$ = concatMap.call(checks$, (s: any) => {
       if (s instanceof CanActivate) {
         return this.runResolve(s.route);
       } else {

diff --git a/modules/@angular/router/test/integration.spec.ts b/modules/@angular/router/test/integration.spec.ts
@@ -577,6 +577,7 @@ describe('Integration', () => {
       TestBed.configureTestingModule({
         providers: [
           {provide: 'resolveTwo', useValue: (a: any, b: any) => 2},
+          {provide: 'resolvePromiseTwo', useValue: (a: any, b: any) => Promise.resolve(2)},
           {provide: 'resolveFour', useValue: (a: any, b: any) => 4},
           {provide: 'resolveSix', useClass: ResolveSix}
         ]

diff --git a/modules/@angular/router/test/router.spec.ts b/modules/@angular/router/test/router.spec.ts
@@ -48,6 +48,23 @@ describe('Router', () => {
       });
     });
 
+    it('should wait for the parent resolve to complete', () => {
+      const parentResolve = new InheritedResolve(InheritedResolve.empty, {data: 'resolver'});
+      const childResolve = new InheritedResolve(parentResolve, {});
+
+      const parent = createActivatedRouteSnapshot('a', {resolve: parentResolve});
+      const child = createActivatedRouteSnapshot('b', {resolve: childResolve});
+
+      const s = new RouterStateSnapshot(
+          'url', new TreeNode(empty.root, [new TreeNode(parent, [new TreeNode(child, [])])]));
+
+      const inj = {get: (token: any) => () => Promise.resolve(`${token}_value`)};
+
+      checkResolveData(s, empty, inj, () => {
+        expect(s.root.firstChild.firstChild.data).toEqual({data: 'resolver_value'});
+      });
+    });
+
     it('should copy over data when creating a snapshot', () => {
       const r1 = new InheritedResolve(InheritedResolve.empty, {data: 'resolver1'});
       const r2 = new InheritedResolve(InheritedResolve.empty, {data: 'resolver2'});