Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(benchpress): fix the license #12090

Merged
merged 1 commit into from Oct 6, 2016
Merged

chore(benchpress): fix the license #12090

merged 1 commit into from Oct 6, 2016

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 5, 2016 •
edited

It's not Apache MIT 2.0, that's a mishmash of Apache 2.0 and MIT

@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 5, 2016
@vicb
Copy link
Contributor

vicb commented Oct 5, 2016

please update the commit comment: chore(benchpress): fix the license

@graingert
chore(benchpress): fix the license
c04d293 
It's not Apache MIT 2.0, that's a mishmash of Apache 2.0 and MIT
@graingert
Copy link
Contributor Author

@vicb done!

@vicb
Copy link
Contributor

vicb commented Oct 5, 2016

thanks !

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 5, 2016
@vicb vicb changed the title The license is MIT chore(benchpress): fix the license Oct 6, 2016
@tbosch tbosch merged commit 230b3b7 into angular:master Oct 6, 2016
@graingert graingert deleted the patch-1 branch October 6, 2016 17:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@graingert @vicb @tbosch @googlebot