Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): don't access view local variables nor pipes in host ex… #12396

Merged
merged 1 commit into from Oct 20, 2016
Merged

fix(compiler): don't access view local variables nor pipes in host ex… #12396

merged 1 commit into from Oct 20, 2016

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Oct 19, 2016

No description provided.

@tbosch tbosch mentioned this pull request Oct 19, 2016
Closed
@tbosch tbosch force-pushed the restrict_host_expressions branch 2 times, most recently from 50ddc33 to f2c8c8b Compare October 19, 2016 21:46
vicb
vicb reviewed Oct 19, 2016
View reviewed changes
modules/@angular/compiler/src/view_compiler/expression_converter.ts
@@ -19,6 +20,23 @@ export interface NameResolver {
createLiteralMap(values: Array<Array<string|o.Expression>>): o.Expression;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one line comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2016
@vicb vicb added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 20, 2016
@vicb
Copy link
Contributor

vicb commented Oct 20, 2016

@tbosch please fix the tests

@tbosch tbosch added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 20, 2016
@alxhub alxhub added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 20, 2016
@alxhub
Copy link
Member

alxhub commented Oct 20, 2016

@tbosch needs rebased, thanks!

@tbosch
Copy link
Contributor Author

tbosch commented Oct 20, 2016

@alxhub Done

@tbosch tbosch added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 20, 2016
@alxhub alxhub merged commit 867494a into angular:master Oct 20, 2016
@tbosch tbosch deleted the restrict_host_expressions branch October 20, 2016 22:34
btrigueiro pushed a commit to btrigueiro/angular that referenced this pull request Oct 21, 2016
@tbosch @btrigueiro
fix(compiler): don't access view local variables nor pipes in host ex…
7640c79 
…pressions (angular#12396)

Fixes angular#12004
Closes angular#12071
IgorMinar pushed a commit that referenced this pull request Oct 27, 2016
@tbosch @IgorMinar
fix(compiler): don't access view local variables nor pipes in host ex…
7bce015 
…pressions (#12396)

Fixes #12004
Closes #12071
@nrgonzalez777 nrgonzalez777 mentioned this pull request Nov 3, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vicb vicb vicb left review comments

Assignees

@tbosch tbosch

Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tbosch @vicb @alxhub @googlebot