Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsickle features #12933

Merged
merged 2 commits into from
Nov 18, 2016
Merged

tsickle features #12933

merged 2 commits into from
Nov 18, 2016

Conversation

alexeagle
Copy link
Contributor

changes angularCompilerOptions:

new property annotationsAs added by Chuck: turns off decorator downleveling for performance
new property annotateForClosureCompiler produces JSDoc needed for closure compiler to work on angular distribution.

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 17, 2016
@alexeagle alexeagle mentioned this pull request Nov 17, 2016
Closed
@alexeagle
Copy link
Contributor Author

This PR fixes the export * and lack of JSDoc annotations in Angular's JS build artifacts, hopefully unblocking #8550

@alexeagle alexeagle force-pushed the tsickle branch 2 times, most recently from 67e13fa to c15fb63 Compare November 17, 2016 02:53
alexeagle added a commit to alexeagle/closure-compiler-angular-bundling that referenced this pull request Nov 17, 2016
@alexeagle
update example to current Angular, based on angular/angular#12933
0559199
alexeagle
alexeagle commented Nov 17, 2016
View reviewed changes
tools/@angular/tsc-wrapped/test/test_support.ts
return fn;
}

export function makeTempDir(): string {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should delete in beforeAll

@alexeagle alexeagle mentioned this pull request Nov 17, 2016
Closed
@tbosch tbosch added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2016
@alexeagle
Copy link
Contributor Author

@IgorMinar I hear there is some debate about the API change for angularCompilerOptions, can we discuss?

@alexeagle alexeagle force-pushed the tsickle branch 2 times, most recently from 93deee0 to 9aea2bd Compare November 18, 2016 00:13
@alexeagle
Copy link
Contributor Author

Resolved that the default behavior for "annotationsAs" will be "static fields", meaning preserve the current behavior.
Set this to "decorators" to skip tsickle for speed. Angular-cli doesn't call ngc anyway so it can skip tsickle on its own. Ionic users could use this new setting.
I don't want to introduce something permanent because we'll have the emit transforms in TS soon, and when we move tsickle there we won't have the performance penalty. Then we'll just have to go through a long deprecation cycle for the new flag.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Nov 18, 2016
@chuckjaz chuckjaz merged commit 664a627 into angular:master Nov 18, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeagle @chuckjaz @tbosch @googlebot