Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): improve error message for undefined providers #13546

Merged
merged 1 commit into from
Dec 28, 2016
Merged

fix(compiler): improve error message for undefined providers #13546

merged 1 commit into from
Dec 28, 2016

Conversation

DzmitryShylovich
Copy link
Contributor

Closes #10835

@vicb vicb added action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Dec 22, 2016
@hansl
Copy link
Contributor

hansl commented Dec 27, 2016

Hi @DzmitryShylovich,

Could you rebase this PR on top of the latest master, please? Thanks!

@hansl hansl added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Dec 27, 2016
@DzmitryShylovich
Copy link
Contributor Author

@hansl done

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 28, 2016
@hansl hansl merged commit 6b02b80 into angular:master Dec 28, 2016
@DzmitryShylovich DzmitryShylovich deleted the gh/10835 branch March 31, 2017 21:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@DzmitryShylovich @hansl @vicb @googlebot