fix(platform-browser): should only add styles with native encapsulation in shadow DOM #14313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DzmitryShylovich
force-pushed
the
gh/7887
branch
from
976884e
to
c6c8429
Compare
DzmitryShylovich
changed the title
|
Test please? |
DzmitryShylovich
force-pushed
the
gh/7887
branch
2 times, most recently
from
432f086
to
eca198e
Compare
…on in shadow DOM Closes angular#7887
DzmitryShylovich
force-pushed
the
gh/7887
branch
from
eca198e
to
f1e826a
Compare
|
@mhevery added a test |
mhevery
approved these changes
Feb 10, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…on in shadow DOM (angular#14313) Closes angular#7887 PR Close angular#14313
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…on in shadow DOM (angular#14313) Closes angular#7887 PR Close angular#14313
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7887
Description:
The origin of the issue is that we add shadow root element into DomSharedStylesHost's hosts here so all styles from other component will be added to the shadow DOM too http://plnkr.co/edit/M785PCAb3Hc7WLD7EKyB
Don't see why it's required + 0 tests failed when I removed it, but this is the only usage of
DomSharedStylesHost.addHostso it's probably necessary for something :)If it's ok I will add a test