Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aio): enhance unit test experience with karma-jasmine-html-reporter #14392

Closed

Conversation

wardbell
Copy link
Contributor

See related PR 4567 in angular-cli

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Karma browser window presents empty page. Have to dig around in console window to see results. Most people modify tests (with fit and xit) to focus on what they want.

What is the new behavior?
The karma-jasmine-html-report gives a more ergonomic experience. I really like it when I'm working on unit tests. So do my colleagues on the docs team where we have this setup.

It has no ill effects on CI nor on regular users of karma.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@wardbell
Copy link
Contributor Author

Closed by #14611

@wardbell wardbell closed this Feb 23, 2017
@wardbell wardbell deleted the aio-karma-conf-with-kjhtml branch February 23, 2017 00:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants