Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow to provide multiple default testing modules #15054

Merged
merged 1 commit into from Mar 11, 2017

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Mar 10, 2017

This can be used to e.g. add the NoopAnimationsModule by default:

TestBed.initTestEnvironment([
  BrowserDynamicTestingModule,
  NoopAnimationsModule
], platformBrowserDynamicTesting());

This can be used to e.g. add the NoopAnimationsModule by default:

```
TestBed.initTestEnvironment([
  BrowserDynamicTestingModule,
  NoopAnimationsModule
], platformBrowserDynamicTesting());
```
@chuckjaz chuckjaz merged commit 6c8638c into angular:master Mar 11, 2017
@tbosch tbosch deleted the testbed branch March 17, 2017 15:29
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017
…r#15054)

This can be used to e.g. add the NoopAnimationsModule by default:

```
TestBed.initTestEnvironment([
  BrowserDynamicTestingModule,
  NoopAnimationsModule
], platformBrowserDynamicTesting());
```
@seawave23
Copy link

can you tell something about the performance effects when adding something in there as a module? I tried to use that like a testing default, but stuffed with all modules that appear very often in my tests (MaterialModule, FlexLayoutModule, ReactiveFormsModule...) to just import them in one central place and make my separate test files smaller. The test performance went down from 1:30 to over 5:00 min and it seems like Angular magic what is going on there because it's really only called once. Whereas importing a module with all singleton providers was a time gain.

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
…r#15054)

This can be used to e.g. add the NoopAnimationsModule by default:

```
TestBed.initTestEnvironment([
  BrowserDynamicTestingModule,
  NoopAnimationsModule
], platformBrowserDynamicTesting());
```
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
…r#15054)

This can be used to e.g. add the NoopAnimationsModule by default:

```
TestBed.initTestEnvironment([
  BrowserDynamicTestingModule,
  NoopAnimationsModule
], platformBrowserDynamicTesting());
```
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants