New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1 only] feat(compiler): support ICU messages in XLIFF #15068
Conversation
return [].concat(...nodes.map(node => node.visit(this))); | ||
} | ||
} | ||
|
||
// TODO(vicb): add error management (structure) | ||
// Extract messages as xml nodes from the xliff file | ||
class XliffParser implements ml.Visitor { | ||
private _unitMlNodes: ml.Node[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to modify this ?
Is this only to reflect changes in he xmb ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same story as for the XTB loader: translations are first retrieved as string so that ICU messages can be parsed before xml nodes.
LGTM with one question |
|
||
visitExpansionCase(icuCase: ml.ExpansionCase, context: any): any {} | ||
ml.visitAll(this, icu.cases).forEach(c => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing type on c
I hope it also fixes the issue of 2.4.8 - when a bit more complex than just basic "select" statement is not extracted into XLIFF file at all...
where |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #12636
After discussion, we decided to implement the solution 4 from the research document: https://docs.google.com/document/d/1FS02wIBSEbysCoxEqbEmJg3_LyfJ566DZLhhbOUheoA/edit?usp=sharing