Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): ignore errors when evaluating base classes #15560

Merged
merged 1 commit into from Mar 28, 2017

Conversation

chuckjaz
Copy link
Contributor

Fixes #15536

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix

What is the current behavior? (You can also link to an open issue here)

#15536

The static reflector emits errors for base classes it doesn't understand. It should just ignore them.

What is the new behavior?

The static reflector now ignores base classes it doesn't understand in more cases.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2017
@vicb vicb merged commit d438b88 into angular:master Mar 28, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata extractor not ignoring errors when resolving base classes
4 participants