Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: don't send in-page clicks to google analytics #16521

Closed
wardbell opened this issue May 3, 2017 · 1 comment · Fixed by #16567
Closed

aio: don't send in-page clicks to google analytics #16521

wardbell opened this issue May 3, 2017 · 1 comment · Fixed by #16567
Assignees
@wardbell

Comments

@wardbell
Copy link
Contributor

wardbell commented May 3, 2017 •
edited

This issue harvests the remaining open concern from #16293.

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Current implementation sends a tracking event to Google Analytics when a user clicks on a link that navigates within the page (a link with a fragment).

This is by design. See the test for it in PR #16441. But is that really what we want to do?

Expected behavior

If we decide that we should NOT track in-page navigations, make that change.

Update 5/4

We decided to only track doc changes. Don't send in-page clicks.
@wardbell wardbell mentioned this issue May 3, 2017
Closed
@wardbell wardbell added this to TODO in docs-infra May 3, 2017
@wardbell wardbell moved this from TODO to TODO Blockers in docs-infra May 4, 2017
@wardbell wardbell changed the title aio: don't send in-page clicks to google analytics (?) aio: don't send in-page clicks to google analytics May 4, 2017
@wardbell wardbell assigned wardbell and unassigned IgorMinar May 4, 2017
wardbell added a commit to IdeaBlade/angular that referenced this issue May 5, 2017
@wardbell
feat(aio): should not send in-page navigations to Google Analytics
e8bf5b0 
closes angular#16521
Sends `GaService` a url stripped of fragment and query strings.
`GaService` already guards against re-send of the prior url so it will only report doc changes.
wardbell added a commit to IdeaBlade/angular that referenced this issue May 5, 2017
@wardbell
feat(aio): should not send in-page navigations to Google Analytics
31d73ed 
closes angular#16521
`LocationService` sends `GaService` a url stripped of fragment and query strings.
`GaService` already guards against re-send of the prior url so it will only report doc changes.
@wardbell wardbell mentioned this issue May 5, 2017
Merged
3 tasks
@wardbell wardbell moved this from TODO Blockers to REVIEW in docs-infra May 5, 2017
petebacondarwin pushed a commit that referenced this issue May 5, 2017
@wardbell @petebacondarwin
feat(aio): should not send in-page navigations to Google Analytics
3e33482 
closes #16521
`LocationService` sends `GaService` a url stripped of fragment and query strings.
`GaService` already guards against re-send of the prior url so it will only report doc changes.
@petebacondarwin petebacondarwin removed this from REVIEW in docs-infra May 5, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@wardbell
feat(aio): should not send in-page navigations to Google Analytics
e3d49a7 
closes angular#16521
`LocationService` sends `GaService` a url stripped of fragment and query strings.
`GaService` already guards against re-send of the prior url so it will only report doc changes.
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@wardbell @juleskremer
feat(aio): should not send in-page navigations to Google Analytics
5f86a20 
closes angular#16521
`LocationService` sends `GaService` a url stripped of fragment and query strings.
`GaService` already guards against re-send of the prior url so it will only report doc changes.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wardbell wardbell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aio): should not send in-page navigations to Google Analytics IdeaBlade/angular
2 participants
@wardbell @IgorMinar