Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aio): should not send in-page navigations to Google Analytics #16567

Merged
merged 1 commit into from
May 5, 2017

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented May 5, 2017

closes #16521
LocationService sends GaService a url stripped of fragment and query strings.
GaService already guards against re-send of the prior url so it will only report doc changes.


Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

closes angular#16521
`LocationService` sends `GaService` a url stripped of fragment and query strings.
`GaService` already guards against re-send of the prior url so it will only report doc changes.
@wardbell wardbell added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels May 5, 2017
@wardbell wardbell self-assigned this May 5, 2017
@wardbell wardbell added this to REVIEW in docs-infra May 5, 2017
@mary-poppins
Copy link

The angular.io preview for 31d73ed is available here.

@petebacondarwin petebacondarwin added cla: yes action: merge The PR is ready for merge by the caretaker and removed cla: yes action: review The PR is still awaiting reviews from at least one requested reviewer labels May 5, 2017
@petebacondarwin petebacondarwin merged commit 3e33482 into angular:master May 5, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra May 5, 2017
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra May 5, 2017
@wardbell wardbell deleted the aio-ga-no-track-hash branch May 7, 2017 16:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio: don't send in-page clicks to google analytics
5 participants