-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(animations): API doc misspelled word #16554
docs(animations): API doc misspelled word #16554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the commit messages (which also break CI). Can you please merge the commits and use animations
for subject?
Also overlaps with #16508 which is approved for merge. For full credit, remove the first commit (covered separately in #16508) and just keep the second. We can merge it then. Right now, we can't merge it because the first commit violates the commit message naming rules enforced by CI. There is good reason for you confusion There is a guide called "animations" (plural) and the Angular module is called "animations". By beginning your commit with "docs(animations)", you're telling us that you're making a change to the Angular module API docs. Which you ARE in the second commit. You're also making a change to the guide documentation. Those kinds of changes should begin "docs(aio): ". In your case it might be something like "docs(aio): Animations guide duplicate word removed". The two kinds of commits should be in separate PRs. Your guide commit is already in the separate PR #16508 and is good to go. This PR #16554 should be devoted to the Angular module API docs fix. The reason we separate these is that pure guide fixes don't touch Angular code and are much easier to approve and merge than API docs fixes. Even a simple documentation change that touches code, as this PR #16554 does, has a higher bar to approval. How the world is going to understand these distinctions is beyond me. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@wardbell sorry I've gotten these two changes into a git mess. Working on it |
8323339
to
a2a8dfb
Compare
CLAs look good, thanks! |
Thanks. Now moving to the right person. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
currently here it says at different statrting/ending times
What is the new behavior?
should say at different starting/ending times
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: