refactor(compiler-cli): move the expression expression type checker #16562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
reviewed
May 5, 2017
|
|
||
| export interface ExpressionDiagnosticsContext { event?: boolean; } | ||
|
|
||
| export enum DiagnosticKind { |
There was a problem hiding this comment.
Consider moving this out of this file as it seems more general than the scope of this file.
tbosch
reviewed
May 5, 2017
| return result; | ||
| } | ||
|
|
||
| export function getExpressionScope( |
tbosch
reviewed
May 5, 2017
packages/compiler-cli/index.ts
Outdated
| export {DiagnosticTemplateInfo, ExpressionDiagnostic, getExpressionDiagnostics, getExpressionScope, getTemplateExpressionDiagnostics} from './src/diagnostics/expression_diagnostics'; | ||
| export {AstType, ExpressionDiagnosticsContext, TypeDiagnostic} from './src/diagnostics/expression_type'; | ||
| export {BuiltinType, DeclarationKind, Definition, PipeInfo, Pipes, Signature, Span, Symbol, SymbolDeclaration, SymbolQuery, SymbolTable} from './src/diagnostics/symbols'; | ||
| export {getClassFromStaticSymbol, getClassMembers, getClassMembersFromDeclaration, getPipesTable, getSymbolQuery} from './src/diagnostics/typescript_symbols'; |
There was a problem hiding this comment.
These exports are only used for tests, right? Consider using a deep import in the tests then.
This way it is clearer which methods are supposed to be used (e.g. by the language service) and which ones are just helpers.
tbosch
reviewed
May 5, 2017
| import {getExpressionDiagnostics, getExpressionScope} from './expressions'; | ||
| import {HtmlAstPath} from './html_path'; | ||
| import {NullTemplateVisitor, TemplateAstChildVisitor, TemplateAstPath} from './template_path'; | ||
| import {getExpressionDiagnostics} from './expressions'; |
There was a problem hiding this comment.
This also exists in the compiler-cli now, did you forget to delete it from the language service?
tbosch
approved these changes
May 5, 2017
chuckjaz
force-pushed
the
move-expression-diagnostics
branch
3 times, most recently
from
a1cc5c9
to
0dbda8a
Compare
The expression type checker moved from the language service to the compiler-cli in preparation to using it to check template expressions.
chuckjaz
force-pushed
the
move-expression-diagnostics
branch
from
0dbda8a
to
1b6a93d
Compare
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ngular#16562) The expression type checker moved from the language service to the compiler-cli in preparation to using it to check template expressions.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ngular#16562) The expression type checker moved from the language service to the compiler-cli in preparation to using it to check template expressions.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expression type checker moved from the language service
to the compiler-cli in preparation to using it to check
template expressions.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The template type checker is part of the language service.
What is the new behavior?
The template type checker is part of the compiler cli.
Does this PR introduce a breaking change? (check one with "x")