Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix projected change detection #16592

Closed
wants to merge 2 commits into from
Closed

Fix projected change detection #16592

wants to merge 2 commits into from

Commits on May 5, 2017

  1. fix(core): projected views should be dirty checked when the declaring… 

    … component is dirty checked.

Previously a projected view was only dirty checked when the 
component in which it was inserted was dirty checked.

This fix changes the behavior so that a view is also dirty checked if
the declaring component is dirty checked.

Note: This does not change the order of change detection,
only the fact whether a projected view is dirty checked or not.

Fixes angular#14321
    @tbosch
    tbosch committed May 5, 2017
    Configuration menu
    Copy the full SHA
    bdd9a16 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2017

  1. fix(core): detach projected views when a parent view is destroyed 

    This also clarifies via a test 
that we only update projected views when the view is created or destroyed,
but not when it is attached/detached/moved.

Fixes angular#15578
    @tbosch
    tbosch committed May 8, 2017
    Configuration menu
    Copy the full SHA
    1b32dd7 View commit details
    Browse the repository at this point in the history