Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): move links from nav groups to items #16605

Merged

Conversation

petebacondarwin
Copy link
Member

Fundamentals and Techniques nav groups we also links to pages. This caused
counterintuitive behaviour when clicking on them.

This commit moves each link from the group item to a children item, called
Introduction.

Closes #16604

Fundamentals and Techniques nav groups we also links to pages. This caused
counterintuitive behaviour when clicking on them.

This commit moves each link from the group item to a children item, called
Introduction.

Closes angular#16604
@petebacondarwin petebacondarwin added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels May 6, 2017
@petebacondarwin petebacondarwin added this to REVIEW in docs-infra May 6, 2017
@mary-poppins
Copy link

The angular.io preview for 9d9eebd is available here.

Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wardbell wardbell added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 6, 2017
@wardbell wardbell moved this from REVIEW to MERGE in docs-infra May 6, 2017
@petebacondarwin petebacondarwin merged commit 6dc6777 into angular:master May 7, 2017
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra May 7, 2017
@petebacondarwin petebacondarwin deleted the aio-no-nav-heading-links branch May 7, 2017 07:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio: move feature/technique pages so no header has a URL
4 participants