Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(aio): image sweep #16609

Merged
merged 8 commits into from May 9, 2017
Merged

docs(aio): image sweep #16609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3fbd059
fix(aio): tidy up image styles
petebacondarwin May 8, 2017
fafa075
fix(aio): allow code blocks to clear floated images
petebacondarwin May 6, 2017
07043fa
feat(aio): add a `.clear` class for clearing floating images
petebacondarwin May 6, 2017
d7f6068
docs(aio): general tidy up of image HTML in guides
petebacondarwin May 9, 2017
1bce4e9
docs(aio): use correct anchor for "back to the top" link
petebacondarwin May 9, 2017
1e7a726
build(aio): add `#top-of-page` to path variants for link checking
petebacondarwin May 9, 2017
901f7ec
fix(aio): ensure that headings clear floated images
petebacondarwin May 9, 2017
1802c5c
fix(aio): do not force live-example embedded image to 100% size
petebacondarwin May 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion aio/content/file-not-found.md
View file
Open in desktop
@@ -1,7 +1,7 @@
@description

<div class="nf-container l-flex-wrap flex-center">
<img src="assets/images/support/angular-404.svg" width="300px" height="300px"/>
<img src="assets/images/support/angular-404.svg" width="300" height="300"/>
<div class="nf-response l-flex-wrap">
<h1 class="no-toc">Page Not Found</h1>
<p>We're sorry. The page you are looking for cannot be found.</p>
Expand Down
215 changes: 32 additions & 183 deletions aio/content/guide/animations.md
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions aio/content/guide/aot-compiler.md
View file
Open in desktop
Expand Up @@ -605,7 +605,7 @@ showing exactly which application and Angular modules and classes are included i
Here's the map for _Tour of Heroes_.

<a href="generated/images/guide/aot-compiler/toh-pt6-bundle.png" title="View larger image">
<figure class='image-display'>
<img src="generated/images/guide/aot-compiler/toh-pt6-bundle.png" alt="toh-pt6-bundle"></img>
<figure>
<img src="generated/images/guide/aot-compiler/toh-pt6-bundle.png" alt="toh-pt6-bundle" width="700">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raw image is super big. A width of 700px is about all you can manage on a screen that is at the breakpoint of 1300px before the max-width: 100% kicks in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we resize the image then (and save the cost of downloading it)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but that was outside of my remit :-P
I'll create an issue to track it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #16678

</figure>
</a>