Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aio): use the current version in the version picker #16916

Merged
merged 1 commit into from
May 22, 2017

Conversation

petebacondarwin
Copy link
Member

Previously we hardcoded the current version into the navigation items.
Now only previous versions are included there. The current version is
computed from the currentVersion info.

Closes #16909

Previously we hardcoded the current version into the navigation items.
Now only previous versions are included there. The current version is
computed from the currentVersion info.

Closes angular#16909
@petebacondarwin petebacondarwin added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer type: bug/fix labels May 21, 2017
@petebacondarwin petebacondarwin added this to REVIEW in docs-infra May 21, 2017
@mary-poppins
Copy link

The angular.io preview for 587e4fe is available here.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. In the future we should find a way to allow switching between versions (especially from older to newer).

@petebacondarwin petebacondarwin merged commit ce18fdb into angular:master May 22, 2017
@petebacondarwin petebacondarwin removed this from REVIEW in docs-infra May 22, 2017
@petebacondarwin petebacondarwin deleted the aio-version-picker branch May 24, 2017 16:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs are out of date (4.0 instead of 4.1)
4 participants