docs(aio): update headers for toc #16969
Conversation
aio/content/guide/webpack.md
Outdated
| @@ -781,7 +774,7 @@ Here again are the TypeScript entry-point files that define the `polyfills` and | |||
|
|
|||
| {@a highlights} | |||
|
|
|||
| ### Highlights | |||
| ## Highlights | |||
There was a problem hiding this comment.
I am not sure about this, but happy with it if you are.
There was a problem hiding this comment.
In fact, you are right about this one. Not sure what was I thinking about. Or even noToc for this one.
aio/content/guide/router.md
Outdated
| @@ -3862,7 +3751,7 @@ drop the `canLoad` guard and rely on the [CanActivate](guide/router#can-activate | |||
| Preloading every lazy loaded modules works well in many situations, | |||
| but it isn't always the right choice, especially on mobile devices and over low bandwidth connections. | |||
| You may choose to preload only certain feature modules, based on user metrics and other business and technical factors. | |||
|
|
|||
| rm | |||
There was a problem hiding this comment.
This is called: Multiple monitors and not being sure where your focus is at
aio/content/guide/ngmodule-faq.md
Outdated
| @@ -550,7 +486,8 @@ from components outside the `AppComponent` tree. This is a rare use case. | |||
|
|
|||
| More generally, [prefer registering providers in modules](guide/ngmodule-faq#q-component-or-module) to registering in components. | |||
|
|
|||
| ### Discussion | |||
| <h3 class="noToc">Discussion</h3> | |||
There was a problem hiding this comment.
noToc will work, but no-toc is what we use in most places 😃
That said, why no ToC?
aio/content/guide/aot-compiler.md
Outdated
| Learn how to use ahead-of-time compilation. | ||
|
|
||
| @description | ||
| # Ahead-of-Time Compilation | ||
|
|
||
| This cookbook describes how to radically improve performance by compiling _ahead-of-time_ (AOT) | ||
| during a build process. | ||
|
|
||
| {@a toc} |
| @@ -136,7 +124,7 @@ Now when the app runs, the `myHighlight` directive highlights the paragraph text | |||
|
|
|||
| <div class="l-sub-section"> | |||
|
|
|||
| ### Your directive isn't working? | |||
| <h3 class="noToc">Your directive isn't working?</h3> | |||
There was a problem hiding this comment.
noToc will work, but we use no-toc in most places 😁
Foxandxss
force-pushed
the
aio-more-toc-work
branch
from
5c0b392
to
64d38f8
Compare
|
Fixed concerns. |
|
LGTM as soon as Travis is green 😁 |
|
The errors are due to inline tags breaking for some reason. I will look into it |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
petebacondarwin
added
the
action: cleanup
|
@Foxandxss - please squash my commit into yours and then mark as |
|
@IgorMinar - can you approve the docs change to |
Foxandxss
force-pushed
the
aio-more-toc-work
branch
from
1053ef4
to
fc6da8b
Compare
|
CLAs look good, thanks! |
|
@petebacondarwin done. |
petebacondarwin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Verified that there are no weird "entry" in the ToC, removed all the commented out toc (now that I verified that they are nice) and changed the
@titleto h1 (#) continuing Ward's work.