fix(animations): use a lightweight renderer for non-animation components #17003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
force-pushed
the
lightweight_renderer
branch
from
9e61f8d
to
a6bf832
Compare
matsko
force-pushed
the
lightweight_renderer
branch
2 times, most recently
from
9ad9e1f
to
8f5b441
Compare
matsko
changed the title
tbosch
reviewed
May 25, 2017
|
|
||
| import {AnimationDriver} from './animation_driver'; | ||
| import {getOrSetAsInMap, listenOnPlayer, makeAnimationEvent, normalizeKeyframes, optimizeGroupPlayer} from './shared'; | ||
|
|
||
| const EMPTY_PLAYER_ARRAY: AnimationPlayer[] = []; | ||
| const ANIMATE_EPOCH_ATTR = 'ng-animate-epoch'; |
tbosch
reviewed
May 25, 2017
| // cache the delegates to find out which cached delegate can | ||
| // be used by which cached renderer | ||
| const delegate = this.delegate.createRenderer(hostElement, type); | ||
| let renderer: BaseAnimationRenderer|undefined = this._rendererCache.get(delegate); |
There was a problem hiding this comment.
move renderer inside of the if, as it is not needed anywhere else.
tbosch
reviewed
May 25, 2017
| public destroyNode: ((node: any) => any)|null = null; | ||
| public microtaskCount: number = 0; | ||
| export class BaseAnimationRenderer implements Renderer2 { | ||
| public namespaceId: string = ''; |
There was a problem hiding this comment.
take the namespaceId in the constructor, and make it protected.
tbosch
reviewed
May 25, 2017
| this.delegate.removeStyle(el, style, flags); | ||
| } | ||
|
|
||
| setProperty(el: any, name: string, value: any): void { | ||
| if (name.charAt(0) != '@') { |
There was a problem hiding this comment.
I think this check is not needed...
tbosch
reviewed
May 25, 2017
| this.delegate.appendChild(parent, newChild); | ||
| this._engine.onInsert(this._namespaceId, newChild, parent, false); | ||
| listen(target: any, eventName: string, callback: (event: any) => boolean | void): () => void { | ||
| if (eventName.charAt(0) == '@') { |
There was a problem hiding this comment.
Why is this logic needed for the base renderer?
There was a problem hiding this comment.
I.e. it probably should go into the regular AnimationRenderer.
tbosch
reviewed
May 25, 2017
| private delegate: RendererFactory2, private _engine: AnimationEngine, private _zone: NgZone) { | ||
| _engine.onRemovalComplete = (element: any, delegate: any) => { | ||
| private delegate: RendererFactory2, private engine: AnimationEngine, private _zone: NgZone) { | ||
| engine.onRemovalComplete = (element: any, delegate: any) => { |
There was a problem hiding this comment.
type the delegate to be a RendererV2.
tbosch
approved these changes
May 25, 2017
matsko
force-pushed
the
lightweight_renderer
branch
from
8f5b441
to
4200ab9
Compare
mhevery
approved these changes
May 26, 2017
chuckjaz
added a commit
to chuckjaz/angular
that referenced
this pull request
May 26, 2017
… components (angular#17003)" This reverts commit 3ab86bd.
matsko
added a commit
to matsko/angular
that referenced
this pull request
May 26, 2017
…nts (angular#17003) This reverts commit c0981b8.
matsko
added a commit
to matsko/angular
that referenced
this pull request
May 26, 2017
…nts (angular#17003) This reverts commit c0981b8.
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
… components (angular#17003)" This reverts commit 3ab86bd.
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…nts (angular#17003) This reverts commit c0981b8.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
… components (angular#17003)" This reverts commit 3ab86bd.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…nts (angular#17003) This reverts commit c0981b8.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.