New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(animations): do not place enterId values on elements for querying purposes #17150

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
6 participants
@matsko
Member

matsko commented Jun 1, 2017

No description provided.

@googlebot googlebot added the cla: yes label Jun 1, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 1, 2017

The angular.io preview for 59e4049 is available here.

mary-poppins commented Jun 1, 2017

The angular.io preview for 59e4049 is available here.

const epoch = (isRemoval ? -1 : 1) * this.currentEpochId;
setAttribute(element, ANIMATE_EPOCH_ATTR, epoch);
}
updateElementEpoch(element: any, isRemoval?: boolean) { this.collectedElements.push(element); }

This comment has been minimized.

@gkalpak

gkalpak Jun 1, 2017

Member

Is isRemoval needed any more?

@gkalpak

gkalpak Jun 1, 2017

Member

Is isRemoval needed any more?

@mhevery

mhevery approved these changes Jun 1, 2017

@vicb vicb merged commit ad6a57e into angular:master Jun 1, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
code-review/pullapprove Approved by all reviewer groups.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment