fix(compiler): report reference to ambient symbols as errors #17978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 1e30901 at https://pr17978-1e30901.ngbuilds.io/. |
|
This ends up being a breaking change in that programs that were incorrectly compiled but happened to work are now reported as errors. This change should be delayed until 5.0 |
|
You can preview 31a4db7 at https://pr17978-31a4db7.ngbuilds.io/. |
|
You can preview 80f8b79 at https://pr17978-80f8b79.ngbuilds.io/. |
|
Obsolete |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15188
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The compiler will report an internal error message when an AOT application uses an ambient symbol that is unsupported by AOT.
Issue Number: #15188
What is the new behavior?
A more reasonable error is produced.
Does this PR introduce a breaking change?