Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): remove deprecated `NgTemplateOutlet#ngOutletContext` #18780

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@ocombe
Copy link
Contributor

ocombe commented Aug 18, 2017

PR Type

What kind of change does this PR introduce?

[ ] Other... Please describe: removing deprecated code

What is the current behavior?

NgTemplateOutlet#ngOutletContext is deprecated since v4.

What is the new behavior?

NgTemplateOutlet#ngOutletContext has been removed as it was deprecated since v4. Use NgTemplateOutlet#ngTemplateOutletContext instead.

Does this PR introduce a breaking change?

[x] Yes
refactor(common): remove deprecated `NgTemplateOutlet#ngOutletContext`
BREAKING CHANGE: `NgTemplateOutlet#ngOutletContext` has been removed as it was deprecated since v4. Use `NgTemplateOutlet#ngTemplateOutletContext` instead.
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Aug 18, 2017

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource left a comment

It LGTM if we can remove deprecated API in Angular 5.

@vicb

vicb approved these changes Aug 18, 2017

@vicb

This comment has been minimized.

Copy link
Contributor

vicb commented Aug 18, 2017

Need approval from @mhevery @IgorMinar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.