Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove deprecated `Testability#findBindings` #18782

Closed

Conversation

Projects
None yet
5 participants
@ocombe
Copy link
Contributor

ocombe commented Aug 18, 2017

PR Type

What kind of change does this PR introduce?

[ ] Other... Please describe: removing deprecated code

What is the current behavior?

Testability#findBindings is deprecated since v4.

What is the new behavior?

Testability#findBindings has been removed as it was deprecated since v4. Use Testability#findProviders instead.

Does this PR introduce a breaking change?

[x] Yes
refactor(core): remove deprecated `Testability#findBindings`
BREAKING CHANGE: `Testability#findBindings` has been removed as it was deprecated since v4. Use `Testability#findProviders` instead.
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Aug 18, 2017

You can preview 492788c at https://pr18782-492788c.ngbuilds.io/.

@vicb

vicb approved these changes Aug 18, 2017

@vicb

This comment has been minimized.

Copy link
Contributor

vicb commented Aug 18, 2017

Need approval from @mhevery @IgorMinar

@mhevery mhevery closed this in f2a2a6b Aug 18, 2017

@ocombe ocombe deleted the ocombe:remove-testability-find-bindings branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.