Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable sass under bazel #18848

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions integration/bazel/WORKSPACE
Expand Up @@ -18,13 +18,3 @@ local_repository(
name = "angular",
path = "node_modules/@angular/bazel",
)

git_repository(
name = "io_bazel_rules_sass",
remote = "https://github.com/bazelbuild/rules_sass.git",
tag = "0.0.2",
)

load("@io_bazel_rules_sass//sass:sass.bzl", "sass_repositories")

sass_repositories()
13 changes: 2 additions & 11 deletions integration/bazel/src/hello-world/BUILD.bazel
@@ -1,19 +1,10 @@
package(default_visibility = ["//visibility:public"])
load("@angular//:index.bzl", "ng_module")
load("@io_bazel_rules_sass//sass:sass.bzl", "sass_binary")

sass_binary(
name = "styles",
src = "hello-world.component.scss",
deps = [
"//src/shared:colors",
"//src/shared:fonts",
],
)

ng_module(
name = "hello-world",
srcs = glob(["*.ts"]),
tsconfig = "//src:tsconfig.json",
assets = [":styles"],
# TODO(alexeagle): re-enable
# assets = [":styles"],
)
12 changes: 0 additions & 12 deletions integration/bazel/src/hello-world/hello-world.component.scss

This file was deleted.

3 changes: 2 additions & 1 deletion integration/bazel/src/hello-world/hello-world.component.ts
Expand Up @@ -8,7 +8,8 @@ import {Component, NgModule} from '@angular/core';
<input type="text" [value]="name" (input)="name = $event.target.value"/>
`,
// TODO: might be better to point to .scss so this looks valid at design-time
styleUrls: ['./styles.css']
// TODO(alexeagle): re-enable SASS
// styleUrls: ['./styles.css']
})
export class HelloWorldComponent {
name: string = 'world';
Expand Down
13 changes: 0 additions & 13 deletions integration/bazel/src/shared/BUILD.bazel

This file was deleted.

2 changes: 0 additions & 2 deletions integration/bazel/src/shared/_colors.scss

This file was deleted.

2 changes: 0 additions & 2 deletions integration/bazel/src/shared/_fonts.scss

This file was deleted.

3 changes: 2 additions & 1 deletion packages/bazel/package.json
Expand Up @@ -6,10 +6,11 @@
"license": "MIT",
"peerDependencies": {
"@angular/compiler-cli": "0.0.0-PLACEHOLDER",
"@bazel/typescript": "~0.0.7",
"typescript": "~2.3"
},
"repository": {
"type": "git",
"url": "https://github.com/angular/angular.git"
}
}
}