New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform-server): add getComputedStyle implementation #19856
Conversation
091865f
to
bb3b86d
Compare
bb3b86d
to
e91b3ea
Compare
e91b3ea
to
de9ea2a
Compare
Hi - Sorry. I missed the previous one. Can you explain a bit more as to what this PR is trying to do? Also need tests |
@vikerman currently Domino doesn't provide an implementation for This PR implements the method on the server, albeit so far without tests. |
@CaerusKaru CI still gives error and I couldn’t get the error message. |
@ardatan The Circle CI issue is a network timeout, probably because it couldn't access the yarn registry. Try resubmitting your commit (and you might want to rebase from master too). You also need to add unit tests for your method (just to confirm that it works on server-generated elements). |
Thanks. Overall makes sense. Will look into the implementation. Tests would be needed. Put the required ones at https://github.com/angular/angular/blob/master/packages/platform-server/test/integration_spec.ts Thanks! |
return '-' + match.toLowerCase(); | ||
} | ||
|
||
export class ɵCSSStyleDeclaration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curiously, what is this ɵ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a private method identifier. It's an Angular convention. You can find it anywhere, every package uses it.
It looks like If that's not the case (and their impl. is insufficient), it might be worth implementing the patch in Domino itself instead of here. |
Closing this PR based on #19856 (comment). |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Now getComputedStyle method can be used in platform-server with flex-layout etc.
Does this PR introduce a breaking change?
Other information