build: remove local yarn #19981
Merged
build: remove local yarn #19981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
force-pushed
the
build-remove-local-yarn
branch
2 times, most recently
from
4911ddb
to
8a566a7
Compare
gkalpak
added
area: build & ci
IgorMinar
approved these changes
Oct 27, 2017
gkalpak
added
action: merge
We use the globally installed yarn now. The local yarn was used in `check-environment.js` only, which results in the `--integrity` check always failing (if dependencies were installed with the global yarn).
gkalpak
force-pushed
the
build-remove-local-yarn
branch
from
8a566a7
to
e79c7ab
Compare
gkalpak
added
target: patch
vicb
pushed a commit
that referenced
this pull request
Nov 2, 2017
We use the globally installed yarn now. The local yarn was used in `check-environment.js` only, which results in the `--integrity` check always failing (if dependencies were installed with the global yarn).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
A local yarn is used in
check-environment.js, which results in the--integritycheck always failing (if dependencies were installed with the global yarn).What is the new behavior?
The globally installed yarn is used in
check-environment.js(and the--integritydoes not fail unnecessarily).Does this PR introduce a breaking change?
Other information
This has already been fixed on 4.x.