-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: RxJS v5.5 for plunkers and systemjs config #20001
Conversation
Should have been companion to PR angular#19985
You can preview 8e8faa8 at https://pr20001-8e8faa8.ngbuilds.io/. |
I can't reproduce the problem you mention in plnkrs. Can you post an example of a plnkr that throws the |
@gkalpak ... it is related to ReactiveX/rxjs#2971 (comment) |
@mlc-mlapis, related or not I couldn't reproduce it ¯\_(ツ)_/¯. |
I think @wardbell intended to say that the examples cannot using the "lettable operators" at the moment. Reproduction: https://plnkr.co/edit/d0c7m11XUAIZLxY1gcVT (see I think this can be fixed by adding this line to systemjs.config.js:
|
I see. But you can still do: import {switchMap} from 'rxjs/operators/index';
// or
import {switchMap} from 'rxjs/operators/switchMap'; And with So, there shouldn't be anything blocking further changes (or this PR). Is that correct, @wardbell? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the yarn.lock to use 5.5.2? Otherwise lgtm.
I meant the examples yarn.lock file not the aio one. |
Closing this. I will put this changes with more upgrades for v5. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
URGENT - please merge ASAP as we have very little time to update docs before next NG release.
Should have been companion to PR #19985
PROBLEM: Doesn't work! Not building plunkers with RxJS v.5.5.2.
Then when I patch it in a plunker, RxJS v5.2 umd ,
import { switchMap } from 'rxjs/operators/switchMap'
says the umd does NOT have/operators
.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?