Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: RxJS v5.5 for plunkers and systemjs config #20001

Closed
wants to merge 1 commit into from

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Oct 28, 2017

URGENT - please merge ASAP as we have very little time to update docs before next NG release.

Should have been companion to PR #19985

PROBLEM: Doesn't work! Not building plunkers with RxJS v.5.5.2.
Then when I patch it in a plunker, RxJS v5.2 umd , import { switchMap } from 'rxjs/operators/switchMap' says the umd does NOT have /operators.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

@wardbell wardbell self-assigned this Oct 28, 2017
@wardbell wardbell added the target: major This PR is targeted for the next major release label Oct 28, 2017
@mary-poppins
Copy link

You can preview 8e8faa8 at https://pr20001-8e8faa8.ngbuilds.io/.

@wardbell wardbell requested review from Foxandxss and removed request for petebacondarwin and gkalpak October 28, 2017 20:07
@gkalpak
Copy link
Member

gkalpak commented Oct 29, 2017

I can't reproduce the problem you mention in plnkrs. Can you post an example of a plnkr that throws the umd does NOT have /operators error?
Other than that LGTM.

@mlc-mlapis
Copy link
Contributor

@gkalpak ... it is related to ReactiveX/rxjs#2971 (comment)

@gkalpak
Copy link
Member

gkalpak commented Oct 29, 2017

@mlc-mlapis, related or not I couldn't reproduce it ¯\_(ツ)_/¯.
Can you post an example plnkr that throws the error?

@sarunint
Copy link
Contributor

I think @wardbell intended to say that the examples cannot using the "lettable operators" at the moment.

Reproduction: https://plnkr.co/edit/d0c7m11XUAIZLxY1gcVT (see hero-detail.component.ts)

I think this can be fixed by adding this line to systemjs.config.js:

'rxjs/operators': 'npm:rxjs@5.5.2/operators/index.js',

@gkalpak
Copy link
Member

gkalpak commented Oct 29, 2017

I see. But you can still do:

import {switchMap} from 'rxjs/operators/index';
// or
import {switchMap} from 'rxjs/operators/switchMap';

And with 'rxjs/operators': 'npm:rxjs@5.5.2/operators/index.js', you can indeed import for rxjs/operators.

So, there shouldn't be anything blocking further changes (or this PR). Is that correct, @wardbell?

@IgorMinar
Copy link
Contributor

@wardbell @gkalpak going forward we should be using all operators only from rxjs/operators, no deep imports like rxjs/operators/operators.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the yarn.lock to use 5.5.2? Otherwise lgtm.

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 30, 2017
@IgorMinar
Copy link
Contributor

Can you also update the yarn.lock to use 5.5.2? Otherwise lgtm.

I meant the examples yarn.lock file not the aio one.

@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Oct 30, 2017
@Foxandxss
Copy link
Member

Closing this. I will put this changes with more upgrades for v5.

@Foxandxss Foxandxss closed this Nov 1, 2017
@Foxandxss Foxandxss deleted the docs-rxjs-5-5-plunker branch November 1, 2017 19:48
@petebacondarwin petebacondarwin removed this from REVIEW in docs-infra Nov 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants