Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(common): fix mis-ordered lines #20220

Closed
wants to merge 1 commit into from
Closed

Conversation

marob
Copy link
Contributor

@marob marob commented Nov 6, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@gkalpak gkalpak added area: common Issues related to APIs in the @angular/common package action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release type: docs labels Nov 6, 2017
@gkalpak
Copy link
Member

gkalpak commented Nov 6, 2017

Nice catch, @marob 👍
Can you please change the commit message to adhere to our commit message guidelines? E.g. something like docs(common): fix ....

@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 6, 2017
@gkalpak
Copy link
Member

gkalpak commented Nov 6, 2017

Needs approval from common owners.

@marob marob changed the title docs: fix mis-ordered lines docs(common): fix mis-ordered lines Nov 6, 2017
@marob
Copy link
Contributor Author

marob commented Nov 6, 2017

@gkalpak: I've change the MR message. Is that OK or should I change it also on the original commit (how can I do that without having to create a new MR?) ?

@marob
Copy link
Contributor Author

marob commented Nov 6, 2017

Had to create a new MR: #20221

@marob marob closed this Nov 6, 2017
@marob marob deleted the patch-1 branch November 6, 2017 18:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants