fix(benchpress): Allow ignoring navigationStart events in perflog met… #20312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ric.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Benchpress perflog metric will only aggregate perf events after the most recent
navigationStart
event. The assumption is thatnavigationStart
only happens on a page load, but our tests include a component that adds an iframe. Adding the iframe to the DOM also logs anavigationStart
event. This behavior prevents us from testing our components with benchpress.Issue Number: N/A
What is the new behavior?
The default behavior is the same, but now users can optionally ignore navigationStart events if they wish.
Does this PR introduce a breaking change?
Other information