Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchpress): Allow ignoring navigationStart events in perflog met… #20312

Closed
wants to merge 1 commit into from

Conversation

heathkit
Copy link
Contributor

@heathkit heathkit commented Nov 9, 2017

…ric.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The Benchpress perflog metric will only aggregate perf events after the most recent navigationStart event. The assumption is that navigationStart only happens on a page load, but our tests include a component that adds an iframe. Adding the iframe to the DOM also logs a navigationStart event. This behavior prevents us from testing our components with benchpress.

Issue Number: N/A

What is the new behavior?

The default behavior is the same, but now users can optionally ignore navigationStart events if they wish.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@heathkit heathkit force-pushed the benchpress-fix branch 4 times, most recently from 83319de to b7f8d27 Compare November 9, 2017 23:05
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Nov 16, 2017
@mhevery mhevery closed this in 717ac5a Nov 17, 2017
@mhevery mhevery added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Nov 22, 2017
mhevery pushed a commit that referenced this pull request Nov 22, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: benchpress cla: yes hotlist: google target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants