Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): show correct path for mock-heroes code #20323

Closed
wants to merge 1 commit into from

Conversation

brad
Copy link
Contributor

@brad brad commented Nov 10, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Conflicting information is given about where to place the mock-heroes.ts file.

Issue Number: N/A

What is the new behavior?

The path for the file is the same everywhere

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@gkalpak gkalpak added comp: docs action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 10, 2017
@gkalpak
Copy link
Member

gkalpak commented Nov 10, 2017

Good catch! Thx 👍

@jasonaden jasonaden closed this in cf0444b Nov 10, 2017
jasonaden pushed a commit that referenced this pull request Nov 10, 2017
@brad brad deleted the mock-heroes-path branch November 10, 2017 20:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants