Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canonical compiler examples #21374

Closed
wants to merge 4 commits into from
Closed

Add canonical compiler examples #21374

wants to merge 4 commits into from

Commits on Jan 11, 2018

  1. refactor(ivy): move directive into elementStart 

    We used to have a separate `directive` instruction for instantiating
directives. However, such an instruction requires that directives
are created in the correct order, which would require that template
compiler would have knowledge of all dependent directives. This
would break template compilation locality principle.

This change only changes the APIs to expected form but does
not change the semantics. The semantics will need to be corrected
in subsequent commits. The semantic change needed is to
resolve the directive instantiation error at runtime based on
injection dependencies.
    @mhevery @kara
    mhevery authored and kara committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    b92b183 View commit details
    Browse the repository at this point in the history

  2. test(ivy): add canonical template translation examples 

    This change creates a spec file which contains canonical examples
of how the template compiler will translate templates into expected
output.
    @mhevery @kara
    mhevery authored and kara committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    7b159a0 View commit details
    Browse the repository at this point in the history

  3. refactor(ivy): merged containerStart/containerEnd 

    This separation is no longer needed since directives are now passed into the `container` as an array rather than as child functions of the `containerStart`
    @mhevery @kara
    mhevery authored and kara committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    b8598cd View commit details
    Browse the repository at this point in the history

  4. refactor(ivy): remove type from DirectiveDef 

    This change makes the code cleaner for the user. It does mean
a little bit more work for us since we have to patch the `type` back
into the `DirectiveDef`. However since the patching happens only once
on startup it should not be significant.
    @mhevery @kara
    mhevery authored and kara committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    a5dfa95 View commit details
    Browse the repository at this point in the history