ci: add angular robot config file #21489

ocombe · 2018-01-11T21:20:36Z

PR Type

What kind of change does this PR introduce?

[x] CI related changes

What is the current behavior?

No config file for the Angular Robot

What is the new behavior?

Config file for the Angular Robot

Does this PR introduce a breaking change?

[x] No

IgorMinar · 2018-01-11T22:23:53Z

.github/angular-robot.yml

+  # {{MERGE_LABEL}} will be replaced by the value of the mergeLabel option
+  # {{OVERRIDE_LABEL}} will be replaced by the value of the overrideLabel option
+  # {{PLACEHOLDER}} will be replaced by the list of failing checks
+  mergeRemovedComment: "I don't like to brag, but I just saved you from a horrible, slow and painful death by removing the `{{MERGE_LABEL}}` label. Probably. Maybe...


"saved you" -> "saved this PR"

IgorMinar · 2018-01-11T22:25:43Z

.github/angular-robot.yml

+\nThe following checks are failing:
+\n{{PLACEHOLDER}}
+\n
+\nBut if you think that you know better than me, then please, go ahead, add the `{{OVERRIDE_LABEL}}` label and add an override justification comment for the caretaker. You'll be free to do whatever you want. Don't say that I didn't warn you."


we are removing the override, please update this accordingly.

replace with something like "Please resolve these issues to make it eligible for merging"

IgorMinar · 2018-01-11T22:26:11Z

docs/TRIAGE_AND_LABELS.md

@@ -114,7 +114,7 @@ Every triaged PR must have a `pr_action` label assigned to it:
 * `PR action: review` - work is complete and comment is needed from the reviewers.
 * `PR action: cleanup` - more work is needed from the author.
 * `PR action: discuss` - discussion is needed, to be led by the author.
-* `PR action: merge` - the PR is ready to be merged by the caretaker.
+* `PR action: merge` - the PR is ready to be merged by the caretaker. If the Angular Robot is removing this label, you can add the `override` label to bypass it. See [Special labels](#override) below.


IgorMinar · 2018-01-11T22:26:16Z

docs/TRIAGE_AND_LABELS.md

@@ -160,3 +160,6 @@ Only issues with `cla:yes` should be merged into master.

 ### `aio: preview`
 Applying this label to a PR makes the angular.io preview available regardless of the author. [More info](../aio/aio-builds-setup/docs/overview--security-model.md)
+
+### `override`


IgorMinar · 2018-01-11T22:27:10Z

.github/angular-robot.yml

+    failureText: "The following checks are failing:"
+
+  # comment that will be added to a PR when there is a conflict, leave empty or set to false to disable
+  mergeConflictComment: "Hello? Don't want to hassle you. Sure you're busy. But--this PR has some conflicts that you probably ought to resolve.


"But--this" -> "But this"

IgorMinar · 2018-01-11T22:27:30Z

.github/angular-robot.yml

+    failureText: "The following checks are failing:"
+
+  # comment that will be added to a PR when there is a conflict, leave empty or set to false to disable
+  mergeConflictComment: "Hello? Don't want to hassle you. Sure you're busy. But--this PR has some conflicts that you probably ought to resolve.


conflicts -> merge conflicts

IgorMinar · 2018-01-11T22:31:02Z

.github/angular-robot.yml

+
+  # the comment that will be added when the merge label is removed, leave empty or set to false to disable
+  # {{MERGE_LABEL}} will be replaced by the value of the mergeLabel option
+  # {{OVERRIDE_LABEL}} will be replaced by the value of the overrideLabel option


ocombe · 2018-01-11T22:50:59Z

Ok PR updated!

IgorMinar

a few small changes, otherwise lgtm

IgorMinar · 2018-01-11T22:58:16Z

.github/angular-robot.yml

+    failureText: "The following checks are failing:"
+
+  # comment that will be added to a PR when there is a conflict, leave empty or set to false to disable
+  mergeConflictComment: "Hello? Don't want to hassle you. Sure you're busy. But this PR has some conflicts that you probably ought to resolve.


"conflicts" => "merge conflicts"

IgorMinar · 2018-01-11T23:00:57Z

.github/angular-robot.yml

+    mergeRemovedComment: "I see that you just added the `{{MERGE_LABEL}}` label. It won't do anything good though, because the following checks are still failing:
+  \n{{PLACEHOLDER}}
+  \n
+  \nIf you want your PR to be merged, it has to pass all the checks. But if you have a good reason to want to merge this, please contact the caretaker to let them know."


"If you want your PR to be merged, it has to pass all the checks. If you can't get the PR green due to flakes, please try restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help."

ngbot · 2018-01-12T01:00:10Z

I see that you just added the PR action: merge label. It won't do anything good though, because the following checks are still failing:

statuses failing/pending (continuous-integration/travis-ci/pr, ci/circleci: lint, ci/circleci: build)

If you want your PR to be merged, it has to pass all the checks. But if you have a good reason to want to merge this, please contact the caretaker to let them know.

IgorMinar · 2018-01-12T01:00:24Z

I fixed the issued and forcepushed into this branch

ngbot · 2018-01-12T02:11:45Z

I see that you just added the PR action: merge label. It won't do anything good though, because the following checks are still failing:

missing required label: "cla: yes"

If you want your PR to be merged, it has to pass all the checks. But if you have a good reason to want to merge this, please contact the caretaker to let them know.

PR Close #21489

PR Close angular#21489

angular-automatic-lock-bot · 2019-09-13T05:20:44Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

ocombe added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 11, 2018

ocombe requested a review from IgorMinar January 11, 2018 21:20

googlebot added the cla: yes label Jan 11, 2018

IgorMinar suggested changes Jan 11, 2018

View reviewed changes

ocombe force-pushed the feat/angular-robot-config branch from 17ca280 to f2cea26 Compare January 11, 2018 22:45

ocombe added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jan 11, 2018

angular deleted a comment from ngbot bot Jan 11, 2018

IgorMinar approved these changes Jan 11, 2018

View reviewed changes

ci: add angular robot config file

c7f79d0

IgorMinar force-pushed the feat/angular-robot-config branch from f2cea26 to c7f79d0 Compare January 12, 2018 00:58

IgorMinar approved these changes Jan 12, 2018

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 12, 2018

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker cla: yes labels Jan 12, 2018

IgorMinar added the cla: yes label Jan 12, 2018

alexeagle closed this in 63478d7 Jan 12, 2018

alexeagle pushed a commit that referenced this pull request Jan 12, 2018

ci: add angular robot config file (#21489)

0e59d18

PR Close #21489

ocombe deleted the feat/angular-robot-config branch January 19, 2018 09:38

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

ci: add angular robot config file (angular#21489)

467806f

PR Close angular#21489

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add angular robot config file #21489

ci: add angular robot config file #21489

ocombe commented Jan 11, 2018

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

ocombe commented Jan 11, 2018

IgorMinar left a comment

IgorMinar Jan 11, 2018

IgorMinar Jan 11, 2018

ngbot bot commented Jan 12, 2018

IgorMinar commented Jan 12, 2018

ngbot bot commented Jan 12, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

ci: add angular robot config file #21489

ci: add angular robot config file #21489

Conversation

ocombe commented Jan 11, 2018

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocombe commented Jan 11, 2018

IgorMinar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngbot bot commented Jan 12, 2018

IgorMinar commented Jan 12, 2018

ngbot bot commented Jan 12, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019