Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pullapprove rules now that we allow selfapprovals #21494

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 13 additions & 14 deletions .pullapprove.yml
Expand Up @@ -10,11 +10,11 @@
# brocco - Mike Brocchi
# chuckjaz - Chuck Jazdzewski
# filipesilva - Filipe Silva
# Foxandxss - Jesús Rodríguez
# gkalpak - George Kalpakas
# hansl - Hans Larsen
# IgorMinar - Igor Minar
# jasonaden - Jason Aden
# kapunahelewong - Kapunahele Wong
# kara - Kara Erickson
# matsko - Matias Niemelä
# mhevery - Misko Hevery
Expand Down Expand Up @@ -91,7 +91,7 @@ groups:
users:
- alexeagle #primary
- chuckjaz
- IgorMinar
- IgorMinar #fallback
- vikerman #fallback

build-and-ci:
Expand Down Expand Up @@ -127,8 +127,9 @@ groups:
files:
- "packages/core/*"
users:
- chuckjaz #primary
- mhevery
- mhevery #primary
- chuckjaz
- kara
- vicb
- IgorMinar #fallback

Expand All @@ -139,7 +140,6 @@ groups:
- "packages/platform-browser/animations/*"
users:
- matsko #primary
- chuckjaz #fallback
- mhevery #fallback
- IgorMinar #fallback

Expand Down Expand Up @@ -171,6 +171,7 @@ groups:
- hansl
- filipesilva #fallback
- brocco #fallback
- IgorMinar #fallback

compiler-cli:
conditions:
Expand Down Expand Up @@ -216,9 +217,8 @@ groups:
- "packages/common/http/*"
- "packages/http/*"
users:
- vikerman #primary
- alxhub
- IgorMinar #fallback
- alxhub #primary
- IgorMinar
- mhevery #fallback

language-service:
Expand All @@ -237,7 +237,7 @@ groups:
files:
- "packages/router/*"
users:
- jasonaden
- jasonaden #primary
- vicb
- IgorMinar #fallback
- mhevery #fallback
Expand Down Expand Up @@ -268,8 +268,7 @@ groups:
- "packages/platform-server/*"
users:
- vikerman #primary
# needs secondary
- alxhub
- alxhub #secondary
- vicb
- IgorMinar #fallback
- mhevery #fallback
Expand Down Expand Up @@ -327,11 +326,11 @@ groups:
- "aio/content/navigation.json"
- "aio/content/license.md"
users:
- kapunahelewong
- stephenfluin
- Foxandxss
- petebacondarwin
- gkalpak
- IgorMinar #fallback
- IgorMinar
- mhevery #fallback

angular.io-marketing:
Expand All @@ -345,5 +344,5 @@ groups:
- stephenfluin
- petebacondarwin
- gkalpak
- IgorMinar #fallback
- IgorMinar
- mhevery #fallback