Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in http.md #22058

Closed
wants to merge 1 commit into from
Closed

docs: fix typo in http.md #22058

wants to merge 1 commit into from

Conversation

m-burst
Copy link
Contributor

@m-burst m-burst commented Feb 7, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

There's a typo in the HttpClient docs.

Issue Number: N/A

What is the new behavior?

Typo fixed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kapunahelewong
Copy link
Contributor

Good catch! Thank you for submitting this PR. Would you amend the commit message to be "docs: fix typo in http.md" and tag me when you've done it so I can approve? Thank you!

@m-burst m-burst changed the title fix(aio): fix typo in http.md docs: fix typo in http.md Feb 7, 2018
@m-burst
Copy link
Contributor Author

m-burst commented Feb 7, 2018

@kapunahelewong Done :)

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @m-burst !!

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Feb 8, 2018
@IgorMinar
Copy link
Contributor

@kapunahelewong please add the merge label in the future as well, otherwise the caretaker will not see the pr. thanks

@kapunahelewong
Copy link
Contributor

Oh thank you, @IgorMinar! Now I understand and will be sure to do it in the future.

@mhevery mhevery closed this in c348445 Feb 9, 2018
mhevery pushed a commit that referenced this pull request Feb 9, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq1: low target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants