Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refining code of tutorial 7 routing #22151

Closed
wants to merge 1 commit into from

Conversation

thewillyhuman
Copy link
Contributor

@thewillyhuman thewillyhuman commented Feb 10, 2018

Removed the dead code from hero-detail.component.ts

Fixes #21908

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #21908

What is the new behavior?

import { Component, OnInit} from '@angular/core';

export class HeroDetailComponent implements OnInit {
  hero: Hero;

}

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@jenniferfell jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Jul 23, 2018
@brandonroberts brandonroberts self-assigned this Aug 3, 2018
@brandonroberts brandonroberts added target: patch This PR is targeted for the next patch release docsarea: tutorial labels Aug 3, 2018
Removed the dead code from hero-detail.component.ts

Fixes angular#21908
@brandonroberts brandonroberts changed the title refactor(aio): refining code of tutorial 7 routing docs: refining code of tutorial 7 routing Aug 6, 2018
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2018
@kara kara closed this in 7bf5a43 Aug 7, 2018
kara pushed a commit that referenced this pull request Aug 7, 2018
Removed the dead code from hero-detail.component.ts

Fixes #21908

PR Close #22151
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
Removed the dead code from hero-detail.component.ts

Fixes angular#21908

PR Close angular#22151
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refining the code of Tutorial #7 Routing
6 participants