Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): allow trailing comma in array literal #22277

Closed
wants to merge 1 commit into from
Closed

feat(compiler): allow trailing comma in array literal #22277

wants to merge 1 commit into from

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Feb 17, 2018 •
edited

closes #20773

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #20773

What is the new behavior?

Trailing comma is allowed in Array literal since ES5, it's now supported in Angular as well.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vicb
Copy link
Contributor

vicb commented Feb 17, 2018

please change fix for feat

@vicb vicb added feature Issue that requests a new feature action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Feb 17, 2018
@trotyl trotyl changed the title fix(compiler): allow trailing comma in array literal feat(compiler): allow trailing comma in array literal Feb 17, 2018
@vicb
Copy link
Contributor

vicb commented Feb 17, 2018

cl/186104666

@mgol
Copy link
Member

mgol commented Apr 5, 2018

Anything holding this up?

@ngbot
Copy link

ngbot bot commented Apr 25, 2018

Hi @trotyl! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@jasonaden jasonaden added this to the needsTriage milestone Jan 29, 2019
@mhevery mhevery self-assigned this Dec 2, 2020
@pullapprove pullapprove bot requested a review from JoostK December 2, 2020 21:42
@trotyl @mhevery
feat(compiler): allow trailing comma in array literal
a735d3d 
Allows `[1, 2, ]` syntax in angular expressions.

closes angular#20773
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Dec 2, 2020
@mhevery
Copy link
Contributor

mhevery commented Dec 2, 2020

presubmit

mhevery
mhevery approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: global-approvers

@mhevery mhevery removed the request for review from JoostK December 2, 2020 22:09
@mhevery mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 2, 2020
mhevery pushed a commit that referenced this pull request Dec 2, 2020
@trotyl @mhevery
feat(compiler): allow trailing comma in array literal (#22277)
f7e767f 
Allows `[1, 2, ]` syntax in angular expressions.

closes #20773

PR Close #22277
@mhevery mhevery closed this in 8d613c1 Dec 2, 2020
josephperrott added a commit to josephperrott/angular that referenced this pull request Dec 9, 2020
@josephperrott
Revert "feat(compiler): allow trailing comma in array literal (angula…
e9ccc6d 
…r#22277)"

This reverts commit f7e767f.
josephperrott added a commit that referenced this pull request Dec 9, 2020
@josephperrott
Revert "feat(compiler): allow trailing comma in array literal (#22277)…
5532683 
…" (#40050)

This reverts commit f7e767f.

PR Close #40050
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2021
@pullapprove pullapprove bot removed the area: core Issues related to the framework runtime label Jan 2, 2021
@ngbot ngbot bot removed this from the needsTriage milestone Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker cla: yes feature Issue that requests a new feature target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Literal Array trailing comma in expressions causes error
6 participants
@trotyl @vicb @mgol @mhevery @jasonaden @googlebot