Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct grammar mistakes in CONTRIBUTING.md #22285

Closed
wants to merge 1 commit into from

Conversation

i3anaan
Copy link
Contributor

@i3anaan i3anaan commented Feb 18, 2018

Various grammar mistakes were present in the contribution guidelines
This commit corrects some of them

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Some grammar issues in CONTRIBUTING.md

Issue Number: N/A

What is the new behavior?

Fewer grammar issues in CONTRIBUTING.md

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

My first contribution of hopefully more to come, any feedback is welcome!

Various grammar mistakes were present in the contribution guidelines
This commit corrects some of them
@vicb vicb added action: merge The PR is ready for merge by the caretaker type: docs labels Feb 18, 2018
@ngbot
Copy link

ngbot bot commented Feb 18, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb added the target: patch This PR is targeted for the next patch release label Feb 18, 2018
vicb pushed a commit that referenced this pull request Feb 18, 2018
Various grammar mistakes were present in the contribution guidelines
This commit corrects some of them

PR Close #22285
@vicb vicb closed this in 7c45db3 Feb 18, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
Various grammar mistakes were present in the contribution guidelines
This commit corrects some of them

PR Close angular#22285
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
Various grammar mistakes were present in the contribution guidelines
This commit corrects some of them

PR Close angular#22285
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
Various grammar mistakes were present in the contribution guidelines
This commit corrects some of them

PR Close angular#22285
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants