Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec style #22719

Closed
wants to merge 3 commits into from
Closed

Spec style #22719

wants to merge 3 commits into from

Commits on Mar 14, 2018

  1. test(ivy): add ComponentFixture for cleaner tests.

    @mhevery
    mhevery committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    9c48111 View commit details
    Browse the repository at this point in the history

  2. refactor(ivy): rename class/style to make space for new instruction 

    Rename:
- `elementClass` (short: `k`) => `elementClassNamed` (short: `kn`)
- `elementStyle` (short: `s`) => `elementStyleNamed` (short: `sn`)

Currently `[class.name]` is `elementClass(0, ‘name’, value)`. We would
like to introduce new binding `[class]` which needs a new instruction
ideally `elementClass(0, value)`. Doing the rename creates space
to create such an instruction in subsequent change.
    @mhevery
    mhevery committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    e3257d9 View commit details
    Browse the repository at this point in the history

  3. test(ivy): add canonical compiler spec for class/style 

    Adds a stub for `elementStyle` and `elementClass` instruction
with a canonical spec for the compiler. The spec shows the the
compiler should be using `elementStyle` and `elementClass` instruction
in place of `[class]` and `[style]` bindings respectively.
    @mhevery
    mhevery committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    067e4d9 View commit details
    Browse the repository at this point in the history