Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): do not emit line/char in ngsummary files. #22840

Closed
wants to merge 1 commit into from
Closed

fix(compiler): do not emit line/char in ngsummary files. #22840

wants to merge 1 commit into from

Conversation

rkirov
Copy link
Contributor

@rkirov rkirov commented Mar 17, 2018

Having ngsummaries emit line/char numbers causes white space change to
retrigger upstream recompilations.

@mary-poppins
Copy link

You can preview 3d338aa at https://pr22840-3d338aa.ngbuilds.io/.

@chuckjaz chuckjaz added the target: major This PR is targeted for the next major release label Mar 19, 2018
@rkirov
fix(compiler): do not emit line/char in ngsummary files.
17ce7d4 
Having ngsummaries emit line/char numbers causes white space change to
retrigger upstream recompilations.
@mary-poppins
Copy link

You can preview 17ce7d4 at https://pr22840-17ce7d4.ngbuilds.io/.

@rkirov rkirov requested review from alexeagle and removed request for alexeagle March 19, 2018 22:56
@rkirov rkirov added the action: merge The PR is ready for merge by the caretaker label Mar 19, 2018
@mhevery mhevery closed this in 5c387a7 Mar 19, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@rkirov @leo6104
fix(compiler): do not emit line/char in ngsummary files. (angular#22840)
c703317 
Having ngsummaries emit line/char numbers causes white space change to
retrigger upstream recompilations.

PR Close angular#22840
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@chuckjaz chuckjaz chuckjaz approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rkirov @mary-poppins @alexeagle @chuckjaz @googlebot