Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): remove unnecessary binding from hello world #22848

Closed
wants to merge 1 commit into from
Closed

refactor(ivy): remove unnecessary binding from hello world #22848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 0 additions & 36 deletions packages/core/test/bundling/hello_world/bundle.golden_symbols.json
View file
Open in desktop
Expand Up @@ -14,9 +14,6 @@
{
"name": "NG_PROJECT_AS_ATTR_NAME"
},
{
"name": "NO_CHANGE"
},
{
"name": "Symbol$1"
},
Expand Down Expand Up @@ -44,9 +41,6 @@
{
"name": "baseDirectiveCreate"
},
{
"name": "bindingUpdated"
},
{
"name": "callHooks"
},
Expand Down Expand Up @@ -92,21 +86,9 @@
{
"name": "executeInitHooks"
},
{
"name": "findFirstRNode"
},
{
"name": "findNextRNodeSibling"
},
{
"name": "getDirectiveInstance"
},
{
"name": "getNextLNodeWithProjection"
},
{
"name": "getNextOrParentSiblingNode"
},
{
"name": "getOrCreateTView"
},
Expand All @@ -116,24 +98,12 @@
{
"name": "hostElement"
},
{
"name": "initBindings"
},
{
"name": "initChangeDetectorIfExisting"
},
{
"name": "insertChild"
},
{
"name": "interpolation1"
},
{
"name": "invertObject"
},
{
"name": "isDifferent"
},
{
"name": "isProceduralRenderer"
},
Expand Down Expand Up @@ -185,12 +155,6 @@
{
"name": "text"
},
{
"name": "textBinding"
},
{
"name": "throwErrorIfNoChangesMode"
},
{
"name": "viewAttached"
}
Expand Down
7 changes: 2 additions & 5 deletions packages/core/test/bundling/hello_world/index.ts
View file
Open in desktop
Expand Up @@ -6,20 +6,17 @@
* found in the LICENSE file at https://angular.io/license
*/

import {ɵT as T, ɵdefineComponent as defineComponent, ɵi1 as i1, ɵrenderComponent as renderComponent, ɵt as t} from '@angular/core';
import {ɵT as T, ɵdefineComponent as defineComponent, ɵrenderComponent as renderComponent} from '@angular/core';

class HelloWorld {
name = 'World';

static ngComponentDef = defineComponent({
type: HelloWorld,
tag: 'hello-world',
factory: () => new HelloWorld(),
template: function HelloWorldTemplate(ctx: HelloWorld, cm: boolean) {
if (cm) {
T(0);
T(0, 'Hello World!');
}
t(0, i1('Hello ', ctx.name, '!'));
}
});
}
Expand Down