Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc build/ci improvements #22854

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion aio/tools/examples/run-example-e2e.js
Expand Up @@ -147,7 +147,7 @@ function runProtractorSystemJS(prepPromise, appDir, appRunSpawnInfo, outputFile)
let transpileError = false;

// Start protractor.

console.log(`\n\n=========== Running aio example tests for: ${appDir}`);
const spawnInfo = spawnExt('yarn', ['protractor',
PROTRACTOR_CONFIG_FILENAME,
`--specs=${specFilename}`,
Expand Down Expand Up @@ -199,6 +199,7 @@ function runProtractorAoT(appDir, outputFile) {
// All protractor output is appended to the outputFile.
// CLI version
function runE2eTestsCLI(appDir, outputFile) {
console.log(`\n\n=========== Running aio example tests for: ${appDir}`);
// `--preserve-symlinks` is needed due the symlinked `node_modules/` in each example.
// `--no-webdriver-update` is needed to preserve the ChromeDriver version already installed.
const args = ['e2e', '--preserve-symlinks', '--no-webdriver-update'];
Expand Down
1 change: 0 additions & 1 deletion modules/rollup-test/hello-world.html

This file was deleted.

19 changes: 0 additions & 19 deletions modules/rollup-test/hello_world.js

This file was deleted.

24 changes: 0 additions & 24 deletions modules/rollup-test/hello_world.ts

This file was deleted.

16 changes: 0 additions & 16 deletions modules/rollup-test/index-bundle.html

This file was deleted.

31 changes: 0 additions & 31 deletions modules/rollup-test/index-systemjs.html

This file was deleted.

10 changes: 0 additions & 10 deletions modules/rollup-test/index.html

This file was deleted.

34 changes: 0 additions & 34 deletions modules/rollup-test/package.json

This file was deleted.

42 changes: 0 additions & 42 deletions modules/rollup-test/rollup.config.js

This file was deleted.

20 changes: 0 additions & 20 deletions modules/rollup-test/tsconfig-system.json

This file was deleted.

18 changes: 0 additions & 18 deletions modules/rollup-test/tsconfig.json

This file was deleted.

3 changes: 1 addition & 2 deletions modules/tsconfig.json
Expand Up @@ -28,8 +28,7 @@
"benchmarks/src/old",
"benchmarks/src/**/index_aot.ts",
"benchmarks_external",
"payload_tests",
"rollup-test"
"payload_tests"
],
"angularCompilerOptions": {
"skipTemplateCodegen": true
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/render3/component.ts
Expand Up @@ -136,7 +136,8 @@ export function renderComponent<T>(
// Create element node at index 0 in data array
elementNode = hostElement(hostNode, componentDef);
// Create directive instance with n() and store at index 1 in data array (el is 0)
component = rootContext.component = baseDirectiveCreate(1, componentDef.factory(), componentDef) as T;
component = rootContext.component =
baseDirectiveCreate(1, componentDef.factory(), componentDef) as T;
initChangeDetectorIfExisting(elementNode.nodeInjector, component);
} finally {
// We must not use leaveView here because it will set creationMode to false too early,
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Expand Up @@ -7958,5 +7958,5 @@ zip-stream@~0.6.0:
readable-stream "~1.0.26"

zone.js@^0.8.12:
version "0.8.17"
resolved "https://registry.yarnpkg.com/zone.js/-/zone.js-0.8.17.tgz#4c5e5185a857da8da793daf3919371c5a36b2a0b"
version "0.8.20"
resolved "https://registry.yarnpkg.com/zone.js/-/zone.js-0.8.20.tgz#a218c48db09464b19ff6fc8f0d4bb5b1046e185d"