Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): prefix private-export (barred-latin-o) symbols #23007

Closed

Conversation

Projects
None yet
5 participants
@alexeagle
Copy link
Contributor

commented Mar 26, 2018

This allows a bundle index to be re-exported by a higher-level module without fear of collisions.
Under bazel, we always set the prefix to be underscore-joined workspace, package, label

@alexeagle alexeagle requested a review from chuckjaz Mar 26, 2018

@googlebot googlebot added the cla: yes label Mar 26, 2018

@alexeagle alexeagle force-pushed the alexeagle:ng_package_namespace_privates branch from df6e5ec to d1e4fd7 Mar 26, 2018

@@ -99,6 +99,10 @@ export interface CompilerOptions extends ts.CompilerOptions {
// meaningful when `flatModuleOutFile` is also supplied. It is otherwise ignored.
flatModuleId?: string;

// A prefix to insert in generated private symbols, e.g. for "my_prefix_" we
// would generate private symbols named like `ɵmy_prefix_a`.
privateSymbolPrefix?: string;

This comment has been minimized.

Copy link
@chuckjaz

chuckjaz Mar 26, 2018

Member

Rename to flatModulePrivateSymbolPrefix

@jelbourn
Copy link
Member

left a comment

LGTM

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 26, 2018

You can preview df6e5ec at https://pr23007-df6e5ec.ngbuilds.io/.

@alexeagle alexeagle force-pushed the alexeagle:ng_package_namespace_privates branch from d1e4fd7 to cdb2674 Mar 26, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 26, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 26, 2018

@alexeagle alexeagle force-pushed the alexeagle:ng_package_namespace_privates branch from cdb2674 to 0c96f97 Mar 26, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 26, 2018

feat(bazel): prefix private-export (barred-latin-o) symbols
This allows a bundle index to be re-exported by a higher-level module without fear of collisions.
Under bazel, we always set the prefix to be underscore-joined workspace, package, label

@alexeagle alexeagle force-pushed the alexeagle:ng_package_namespace_privates branch from 0c96f97 to c395536 Mar 26, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.