feat(bazel): prefix private-export (barred-latin-o) symbols #23007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
ng_package_namespace_privates
branch
from
df6e5ec
to
d1e4fd7
Compare
chuckjaz
approved these changes
Mar 26, 2018
| @@ -99,6 +99,10 @@ export interface CompilerOptions extends ts.CompilerOptions { | |||
| // meaningful when `flatModuleOutFile` is also supplied. It is otherwise ignored. | |||
| flatModuleId?: string; | |||
|
|
|||
| // A prefix to insert in generated private symbols, e.g. for "my_prefix_" we | |||
| // would generate private symbols named like `ɵmy_prefix_a`. | |||
| privateSymbolPrefix?: string; | |||
There was a problem hiding this comment.
Rename to flatModulePrivateSymbolPrefix
|
You can preview df6e5ec at https://pr23007-df6e5ec.ngbuilds.io/. |
alexeagle
force-pushed
the
ng_package_namespace_privates
branch
from
d1e4fd7
to
cdb2674
Compare
|
You can preview d1e4fd7 at https://pr23007-d1e4fd7.ngbuilds.io/. |
|
You can preview cdb2674 at https://pr23007-cdb2674.ngbuilds.io/. |
alexeagle
force-pushed
the
ng_package_namespace_privates
branch
from
cdb2674
to
0c96f97
Compare
|
You can preview 0c96f97 at https://pr23007-0c96f97.ngbuilds.io/. |
This allows a bundle index to be re-exported by a higher-level module without fear of collisions. Under bazel, we always set the prefix to be underscore-joined workspace, package, label
alexeagle
force-pushed
the
ng_package_namespace_privates
branch
from
0c96f97
to
c395536
Compare
|
You can preview c395536 at https://pr23007-c395536.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a bundle index to be re-exported by a higher-level module without fear of collisions.
Under bazel, we always set the prefix to be underscore-joined workspace, package, label