-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ivy): fix flaky tests #23010
test(ivy): fix flaky tests #23010
Conversation
You can preview df8699a at https://pr23010-df8699a.ngbuilds.io/. |
6ab8633
to
8a9d112
Compare
You can preview 6ab8633 at https://pr23010-6ab8633.ngbuilds.io/. |
ab289c2
to
7934539
Compare
You can preview 7934539 at https://pr23010-7934539.ngbuilds.io/. |
You can preview df54f72 at https://pr23010-df54f72.ngbuilds.io/. |
@kara not sure which tests exactly are failing for you in the unpredictable way but I can see some random pass / fail for a few lifecycle-hooks related tests locally. This happens after pulling the latest master but I can see this under Chrome, so probably not FFox specific (assuming that we are actually hitting the same problem...) |
@pkozlowski-opensource I actually can't repro the failures at all locally, but they are failing on Firefox on Travis CI here (but not Chrome): https://travis-ci.org/angular/angular/jobs/358698542 I'm pretty sure it has to do with entering the view in this way, which was only a hack until we could re-write the view container implementation anyway. Reverting the change fixes the tests. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Some lifecycle hook tests are failing on Travis because of the new
enterView
call inViewContainerRef
.