Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): fix flaky tests #23010

Closed
wants to merge 1 commit into from
Closed

test(ivy): fix flaky tests #23010

wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Mar 27, 2018

Some lifecycle hook tests are failing on Travis because of the new enterView call in ViewContainerRef.

@mary-poppins
Copy link

You can preview df8699a at https://pr23010-df8699a.ngbuilds.io/.

@kara kara force-pushed the locality branch 2 times, most recently from 6ab8633 to 8a9d112 Compare March 27, 2018 06:17
@mary-poppins
Copy link

You can preview 6ab8633 at https://pr23010-6ab8633.ngbuilds.io/.

@kara kara force-pushed the locality branch 2 times, most recently from ab289c2 to 7934539 Compare March 27, 2018 06:41
@mary-poppins
Copy link

You can preview 7934539 at https://pr23010-7934539.ngbuilds.io/.

@kara kara changed the title Test test(ivy): fix flaky tests Mar 27, 2018
@kara kara added refactoring Issue that involves refactoring or code-cleanup comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release and removed state: WIP labels Mar 27, 2018
@mary-poppins
Copy link

You can preview df54f72 at https://pr23010-df54f72.ngbuilds.io/.

@pkozlowski-opensource
Copy link
Member

@kara not sure which tests exactly are failing for you in the unpredictable way but I can see some random pass / fail for a few lifecycle-hooks related tests locally. This happens after pulling the latest master but I can see this under Chrome, so probably not FFox specific (assuming that we are actually hitting the same problem...)

@kara
Copy link
Contributor Author

kara commented Mar 27, 2018

@pkozlowski-opensource I actually can't repro the failures at all locally, but they are failing on Firefox on Travis CI here (but not Chrome):

https://travis-ci.org/angular/angular/jobs/358698542

I'm pretty sure it has to do with entering the view in this way, which was only a hack until we could re-write the view container implementation anyway. Reverting the change fixes the tests.

@kara kara requested a review from mhevery March 27, 2018 15:36
@matsko matsko added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 27, 2018
@kara
Copy link
Contributor Author

kara commented Mar 27, 2018

presubmit

@matsko matsko closed this in f739f75 Mar 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants