refactor(ivy): remove pipe references from the template #23032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
action: review
mhevery
approved these changes
Mar 27, 2018
| * @param type Pipe class reference. Needed to extract pipe lifecycle hooks. | ||
| * @param factory A factory for creating a pipe instance. | ||
| * @param pure Whether the pipe is pure. | ||
| */ | ||
| export function definePipe<T>( | ||
| {type, factory, pure}: {type: Type<T>, factory: () => T, pure?: boolean}): PipeDef<T> { | ||
| {name, type, factory, pure}: {name: string, type: Type<T>, factory: () => T, pure?: boolean}): |
There was a problem hiding this comment.
could you add docs here (same as componentDef)
| */ | ||
| export function renderTemplate<T>( | ||
| hostNode: RElement, template: ComponentTemplate<T>, context: T, | ||
| providedRendererFactory: RendererFactory3, host: LElementNode | null, | ||
| directiveRegistry: DirectiveDefListOrFactory | null = null): LElementNode { | ||
| {directives, |
There was a problem hiding this comment.
let's not use {} in args since they are not efficient and require object creation. I think sticking to positional args is safer.
|
You can preview df6def1 at https://pr23032-df6def1.ngbuilds.io/. |
|
You can preview 0849e21 at https://pr23032-0849e21.ngbuilds.io/. |
kara
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all pipe references from the template. This improves locality because host components won't need to know what their pipes are at compile-time.
Template:
{{ name | double }}Generated (before):
Generated (after):