Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: add monitoring and fix a couple of issues (5.2.x) #23093

Closed
wants to merge 4 commits into from
Closed

aio: add monitoring and fix a couple of issues (5.2.x) #23093

wants to merge 4 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 30, 2018

Backporting #22483 to 5.2.x.

@gkalpak
fix(aio): wait for the app to stabilize before registering the SW
416ed31 
This commit also waits for the app to stabilize, before starting to
check for ServiceWorker updates. This avoids setting up a long timeout,
which would prevent the app from stabilizing and thus cause issues with
Protractor.
@gkalpak
refactor(aio): move deployment config tests and helpers around
570e483 
This commit prepares the ground for adding different types of tests.
@gkalpak
fix(aio): fix SW routing RegExp to allow redirecting /api/animate URLs
ffe435a
@gkalpak
ci(aio): add monitoring for angular.io
65fadbb 
This commit configures a periodic job to be run on CircleCI, performing several
checks against the actual apps deployed to production (https://angular.io) and
staging (https://next.angular.io).

Fixes angular#21942
@gkalpak gkalpak changed the title 5.2.x ci aio monitoring aio: add monitoring and fix a couple of issues (5.2.x) Mar 30, 2018
@gkalpak gkalpak mentioned this pull request Mar 30, 2018
Closed
@gkalpak gkalpak added type: bug/fix area: build & ci Related the build and CI infrastructure of the project comp: aio state: WIP action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Mar 30, 2018
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 30, 2018
alxhub pushed a commit that referenced this pull request Mar 30, 2018
@gkalpak @alxhub
fix(aio): wait for the app to stabilize before registering the SW (#2…
650c6e5 
…3093)

This commit also waits for the app to stabilize, before starting to
check for ServiceWorker updates. This avoids setting up a long timeout,
which would prevent the app from stabilizing and thus cause issues with
Protractor.

PR Close #23093
alxhub pushed a commit that referenced this pull request Mar 30, 2018
@gkalpak @alxhub
refactor(aio): move deployment config tests and helpers around (#23093)
0614b2b 
This commit prepares the ground for adding different types of tests.

PR Close #23093
alxhub pushed a commit that referenced this pull request Mar 30, 2018
@gkalpak @alxhub
fix(aio): fix SW routing RegExp to allow redirecting /api/animate U…
55eaeb1 
…RLs (#23093)

PR Close #23093
alxhub pushed a commit that referenced this pull request Mar 30, 2018
@gkalpak @alxhub
ci(aio): add monitoring for angular.io (#23093)
4473da7 
This commit configures a periodic job to be run on CircleCI, performing several
checks against the actual apps deployed to production (https://angular.io) and
staging (https://next.angular.io).

Fixes #21942

PR Close #23093
@alxhub
Copy link
Member

alxhub commented Mar 30, 2018

Closed in 4473da7.

@alxhub alxhub closed this Mar 30, 2018
@gkalpak gkalpak deleted the 5.2.x-ci-aio-monitoring branch April 2, 2018 07:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @alxhub @IgorMinar @googlebot